JGRP-2811 Support time units parsing for property values #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also adds support for kib, mib, gib in size units * Document time and size units
tristantarrant
force-pushed
the
JGRP-2811/timeunits
branch
from
8cecd70
to
d1460d3
Compare
|
|
|
OK, I made some changes and the testsuite passes. Thanks for the contribution, @tristantarrant ! Do you want me to backport this to the 5.3.x branch? |
|
Not strictly necessary. When are you planning on releasing 5.4 ? |
|
5.4 will take some time, I'm working on |
|
and backported... I have issues logging into JIRA, to add 5.3.8 as fix-release, will retry tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/JGRP-2811